D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> wbauer wrote in previewjob.cpp:641
> That line is commented out. Is this intentional?
> I don't see how this will change anything... ;-/

Aw, crap, that's what happens when you have unstaged changes, I was testing 
stuff and acceidentally pushed that wrong state, will fix, thanks for noticing.

Fixed in 62c57a5f78fc754eb0d1d7c6329f063f55792b19 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Wolfgang Bauer]

wbauer added inline comments.

INLINE COMMENTS

> previewjob.cpp:641
>  job->addMetaData(QStringLiteral("plugin"), 
> currentItem.plugin->library());
> +//job->addMetaData(QStringLiteral("enabledPlugins"), 
> enabledPlugins.join(QLatin1Char(',')));
>  if (sequenceIndex) {

That line is commented out. Is this intentional?
I don't see how this will change anything... ;-/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b582cd477f65: [PreviewJob] Send enabled thumbnail plugins 
to the thumbnail slave (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15096?vs=40495=41883#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15096?vs=40495=41883

REVISION DETAIL
  https://phabricator.kde.org/D15096

AFFECTED FILES
  src/widgets/previewjob.cpp

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

broulik added a dependent revision: D15097: [Thumbnailer] Use enabled plugins 
passed in as metadata.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, fvogt, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This way the thumbnailer can use the same enabled plugin configuration as the 
calling application
  
  CCBUG: 388303

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

AFFECTED FILES
  src/widgets/previewjob.cpp

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns