D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos 
mvourlakos added inline comments.

INLINE COMMENTS

> dialog.cpp:910
>  const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) 
> == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint))
> -&& item->window()->mask().isNull();
> +&& !flags().testFlag(Qt::ToolTip);
>  

This positions the plasma taskmanager previews a bit out of place because 
plasma panels are enforcing 2px margin at their edges.

What type of window do you believe should be an exception in order for the 
popup to be placed according to the item that triggered it?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos 
mvourlakos updated this revision to Diff 42536.
mvourlakos added a comment.


  - dont use mask() to identify popups placement

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15821?vs=42510=42536

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos 
mvourlakos added a reviewer: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos 
mvourlakos added a comment.


  F6292209: εικόνα.png 
  [BEFORE: popup placement in plasma panel in !compositing]
  
  F6292214: εικόνα.png 
  [AFTER: popup placement in plasma panel in !compositing]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos 
mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --pop up positioning that was introduced in order to a dock
  pop up to not be placed far for the item triggering the pop up
  broke the plasma panel pop-ups placement in !compositing mode
  because plasma panels are also setting a mask in !compositing
  mode. This fix tries to fix the situation for plasma panels
  and also keep the functionality needed by docks.
  --The tooltips exception for !compositing mode is added because
  docks might also want to place their tooltips not according to
  window geometry or mask but according to their inner elements.

TEST PLAN
  test plasma panels in compositing and !compositing in order to
  confirm functionality
  test Latte dock in order to confirm that popups are still placed
  correctly
  test Latte dock tooltips in !compositing mode in order to confirm
  that can be placed inside the window or mask boundaries

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns