D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  I was talking about the code I changed, which uses QUrl, which can not parse 
the @SSL syntax.
  I tried.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added a comment.


  In D15859#338583 , @mkoller wrote:
  
  > file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works 
since it's standard URL syntax.
  >  file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, 
since it's not a valid URL syntax.
  >
  > 443 is not enabled, so I can't test it, but given the fact that
  >  file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  >  is also not a valid URL syntax, I know it will not work.
  
  
  Oh, you "know"...
  
  See the comment in 
https://www.roelvanlisdonk.nl/2010/05/21/how-to-create-a-windows-explorer-shortcut-on-the-desktop-to-a-sharepoint-document-library/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1c7b47cb677b: allow non-local file:// redirect to a 
Windows WebDav URL (authored by mkoller).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15859?vs=42626=43070#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15859?vs=42626=43070

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works 
since it's standard URL syntax.
  file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, since 
it's not a valid URL syntax.
  
  443 is not enabled, so I can't test it, but given the fact that
  file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  is also not a valid URL syntax, I know it will not work.
  
  And since https://www.webdavsystem.com/server/access/windows
  only talks about UNC path syntax, I even have no clue if this weird syntax 
will ever end up that way in a file:// URL.
  
  I have no idea how my colleagues did produce the file:// URL - for sure not 
manually.
  I just see that I received mails with a file:// URL, not with a UNC syntax

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added a comment.


  There are a few things which would be good to test:
  
  Try if the following URLs work (on windows):
  
  - file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document
  - file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document
  - file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  
  Check if SSL is enabled on the server:
  $> telnet some.server 443
  With dolphin:
  
  - webdavs://some.server/DavWWWRoot/pwa/some/path/to/a/document
  
  At least one of "@80", ":80" should work on windows, as it just states the 
default explicitly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  +2, assuming the commit log doesn't have M$ anymore (the phab review does, 
but you don't use arc apparently so I guess the two things are unrelated)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller updated this revision to Diff 42626.
mkoller added a comment.


  M$ -> windows
  
  About SSL: I have no idea how an SSL url from a sharepoint server would look 
like, since it seems the setup we use does not use ssl.
  The mentioned webdavsystem.com link just describes how it would look like as 
a win-UNC path, but since I receive urls in mail which are not in the unc 
syntax, I'm not sure if they will contain this @ssl token or not

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15859?vs=42603=42626

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  file.cpp
  file.h
  file_unix.cpp
  file_win.cpp

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> file.cpp:338
> +// if we would redirect into the windows world, let's also check for the
> +// DavWWWRoot "token" which in the m$-world tells win explorer to access
> +// a webdav url

Can you please replace the m$. Also, 'Windows' is likely more correct here, MS 
does even do Linux these days ...

> file.cpp:344
> +redir.setPath(redir.path().mid(11));  // remove /DavWWWRoot
> +redir.setScheme(QLatin1String("webdav"));
> +}

Is this also working in all cases for SSL connections? `webdavs` might be 
required.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham added a comment.


  Code change looks pretty sane to me. Can we change "M$" to "MS"  or 
"Microsoft" though? It's not the most professional, and the symbolism is even 
rather dated; there are many many companies that have more money than Microsoft 
these days...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mkoller requested review of this revision.

REVISION SUMMARY
  In our mainly windows company environment, I often receive links in emails 
like this
  file://some.server/DavWWWRoot/pwa/some/path/to/a/document
  
  The files are served by a Sharepoint server, and M$ introduced the special 
"DavWWWRoot" prefix to notify
  then WebDav shall be used.
  
  See https://www.webdavsystem.com/server/access/windows
  
  With this patch I can now nicely click such an URL and get the same as 
colleagues using win get

TEST PLAN
  Using kioclient5 exec URL and clicking such an URL in kmail

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  file.cpp
  file.h
  file_unix.cpp
  file_win.cpp

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns