D15872: Fix Oxygen background gradient for QML modules

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  5.57 is now tagged, so I've landed this.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: ngraham, davidedmundson, filipf, kde-frameworks-devel, michaelh, bruns

D15872: Fix Oxygen background gradient for QML modules

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh, I think I misunderstood your comment, @davidedmundson. You were saying we 
should merge this //after// tagging, duh. Reverted for now, and I'll re-merge 
it after tagging.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: ngraham, davidedmundson, filipf, kde-frameworks-devel, michaelh, bruns

D15872: Fix Oxygen background gradient for QML modules

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3fe124c7f411: Fix Oxygen background gradient for QML 
modules (authored by hwti, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15872?vs=42644&id=55450#toc

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15872?vs=42644&id=55450

REVISION DETAIL
  https://phabricator.kde.org/D15872

AFFECTED FILES
  src/kcmoduleqml.cpp

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  We are really bad at letting reviews get lost and unnoticed. I'm really sorry!
  
  Tagging is on Saturday, so best to merge next week for proper testing.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

[Filip Fila]

filipf added a reviewer: Plasma.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

[Filip Fila]

filipf added a comment.


  Ping.
  
  Is this actually what's been causing the following problem?
  
  F6753947: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

[Loïc Yhuel]

hwti created this revision.
hwti added reviewers: mart, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hwti requested review of this revision.

REVISION SUMMARY
  We need to make the QQuickWidget transparent, so we see the window 
background, which can be a gradient with Oxygen, instead of a solid color which 
doesn't match the top and bottom of the window.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

AFFECTED FILES
  src/kcmoduleqml.cpp

To: hwti, mart, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns