D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-08 Thread Igor Poboiko 
poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-06 Thread Igor Poboiko 
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Verified that this fixes https://bugs.kde.org/show_bug.cgi?id=397242. Can you 
add the following to the summary section:
  
BUG: 397242
FIXED-IN: 5.52
  
  Also please commit after 5.51 is tagged tomorrow.

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-04 Thread Igor Poboiko 
poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  If I move a file (while baloo was not running) and perform `balooctl index` 
on new file
  (so that document Id is not changed), it won't update the path of the file, 
keeping the
  invalid entry in index.
  Explicitly tell Baloo that we want to update everything concerning this file.

TEST PLAN
  1. `echo "hello world" >~/file1`
  2. `balooctl stop`
  3. `mv ~/file1 ~/file2`
  4. `balooctl start && balooctl index ~/file2`
  5. `balooshow file2` and `balooshow -x `
  
  The first command should show the right path, and the second command 
shouldn't complain about bug in Baloo (invalid index entry)

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

AFFECTED FILES
  src/tools/balooctl/indexer.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams