D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:1c564d0b5eb4: Start drawing emblems in the bottom-right 
corner (authored by ngraham).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15947?vs=42864=43030

REVISION DETAIL
  https://phabricator.kde.org/D15947

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #vdg, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  emblems-start-in-bottom-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15947

To: ngraham, #vdg, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15947

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  While writing a HIG page about emblems (D15897 
), we noticed an inconsistency in where 
they're currently placed: All of our icons that have built-in emblems as well 
as all 3rd-party system tray icons put their emblems in the bottom-right 
corner. But when `KIconLoader` it used to add emblems to a regular icon, it 
puts the first emblem in the bottom-left corner.
  
  This arbitrary inconsistency makes it impossible to write a clear rule in the 
HIG about emblem placement. Changing hundreds of icons and 3rd-party apps to 
move all their emblems to the bottom-right corner doesn't seem likely. 
Therefore, this patch adjusts 'KIconLoader` to position the first emblem in the 
bottom-right corner to match existing icons and 3rd-party apps.

TEST PLAN
  Symlink emblem:
  
  Shared folder emblem:
  
  Emblem on a disk in the Places panel:
  
  Folders with multiple emblems:

REPOSITORY
  R302 KIconThemes

BRANCH
  emblems-start-in-bottom-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15947

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns