D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns added a comment.


  In D15993#337880 , @ngraham wrote:
  
  > Congrats, you just fixed the most common Baloo crash. :)
  
  
  Thx - I am just selfish here ;-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2d31a8500edb: [PositionCodec] Avoid crash in case of 
corrupt data (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15993?vs=42992=42995

REVISION DETAIL
  https://phabricator.kde.org/D15993

AFFECTED FILES
  src/codecs/positioncodec.cpp

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns added a comment.


  In D15993#337854 , @ngraham wrote:
  
  > Thanks! Any chance this will fix 
https://bugs.kde.org/show_bug.cgi?id=367480?
  
  
  Absolutely!

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham added a comment.


  Congrats, you just fixed the most common Baloo crash. :)

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480?

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  getDifferentialVarInt* returns a nullptr in case of a decoding error.
  
  See also D11825 .

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

AFFECTED FILES
  src/codecs/positioncodec.cpp

To: bruns, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams