D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices
jtamate added a comment. Just in case, I'm subscribed now to the RSS https://build.kde.org/job/Frameworks/job/kio/rssFailed REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices
jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any review request. With your patch, all the fails from this unit test are gone. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices
dfaure created this revision. dfaure added a reviewer: jtamate. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. TEST PLAN kfileplacesmodeltest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16020 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns
