D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:55eb68ff6364: fallback to dnssd service discovery if smb 
listDir failed on root (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16299?vs=45938=47026

REVISION DETAIL
  https://phabricator.kde.org/D16299

AFFECTED FILES
  CMakeLists.txt
  config-runtime.h.cmake
  smb/CMakeLists.txt
  smb/kio_smb.h
  smb/kio_smb_browse.cpp

To: sitter, #frameworks, #dolphin, broulik
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-discovery

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin, broulik
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> sitter wrote in kio_smb_browse.cpp:508
> https://en.wikipedia.org/wiki/If_and_only_if

How about writing that out in English, then? :) "iff" just looks like a typo in 
this context.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16299#363498 , @sitter wrote:
  
  > If someone has a thought to offer on this please do.
  >  Personally I am somewhat leaning towards assuming that systems should be 
properly configured. The problem with setting the URL to the ip address is that 
it messes with the visual look in the address bar. So, if we want reliable 
resolution and good looks we'd need to resolve each dnssd address (e.g. 
`foobar.local`) to their ip address (e.g. 172.17.0.1) via kdnssd and then 
resolve that back to a hostname via glibc/qhostinfo (e.g. `foobar.sky.net`). 
That way we'd know that the name we have in the end is in fact resolvable by 
the system without aid from dnssd. Speed impact of this aside it also adds 3 
additional points of failure (and KDNSSD currently doesn't implement the 
resolver API it seems).
  
  
  I would recommend assuming DNS and systems are configured properly. I say 
that as someone with ~15 years IT experience. Modern IT networks are so heavily 
reliant on it (ever set up a VMware cluster? phew!), almost nothing works if it 
is not set up properly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added a comment.


// TODO: it may be better to resolve the host to an ip address. dnssd
//   being able to find a service doesn't mean name resolution is
//   properly set up for its domain. So, we may not be able to resolve
//   this without help from avahi. OTOH KDNSSD doesn't have API for this
//   and from a platform POV we should probably assume that if avahi
//   is functional it is also set up as resolution provider.
//   Given the plugin design on glibc's libnss however I am not sure
//   that assumption will be true all the time. ~sitter, 2018
  
  If someone has a thought to offer on this please do.
  Personally I am somewhat leaning towards assuming that systems should be 
properly configured. The problem with setting the URL to the ip address is that 
it messes with the visual look in the address bar. So, if we want reliable 
resolution and good looks we'd need to resolve each dnssd address (e.g. 
`foobar.local`) to their ip address (e.g. 172.17.0.1) via kdnssd and then 
resolve that back to a hostname via glibc/qhostinfo (e.g. `foobar.sky.net`). 
That way we'd know that the name we have in the end is in fact resolvable by 
the system without aid from dnssd. Speed impact of this aside it also adds 3 
additional points of failure (and KDNSSD currently doesn't implement the 
resolver API it seems).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter retitled this revision from "RFC fallback to dnssd service discovery if 
smb listDir failed on root" to "fallback to dnssd service discovery if smb 
listDir failed on root".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov