D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:3501660aa3d7: Add a QIconEnginePlugin to allow QIcon 
deserialization (authored by fvogt).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16305?vs=43893&id=44698

REVISION DETAIL
  https://phabricator.kde.org/D16305

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconengineplugin.cpp
  src/kiconengineplugin.json

To: fvogt, #frameworks, davidedmundson
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16305

To: fvogt, #frameworks, davidedmundson
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-10-31 Thread Luca Beltrame 
lbeltrame added a comment.


  +1.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D16305

To: fvogt, #frameworks
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-10-18 Thread Fabian Vogt 
fvogt created this revision.
fvogt added a reviewer: Frameworks.
Herald added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  This is necessary to allow QIcons with a KIconEngine as engine to deserialize
  properly.
  
  BUG: 399989

TEST PLAN
  Ran the PoC in the bug report, works fine.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16305

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconengineplugin.cpp
  src/kiconengineplugin.json

To: fvogt, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns