D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f7d13812e2c5: [Config] Remove KDE4 config support, stop 
writing arbitrary config files (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16392?vs=44130&id=44171

REVISION DETAIL
  https://phabricator.kde.org/D16392

AFFECTED FILES
  src/lib/indexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fair enough, that's true. Go for it!

REPOSITORY
  R293 Baloo

BRANCH
  excludes

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Stefan Brüns]

bruns added a comment.


  In D16392#347781 , @ngraham wrote:
  
  > Looks good, but what's our transition plan? Does this need any special 
handling for people who already have old config files?
  
  
  Currently, there is some garbage left in a few config files (potentially any 
application which **writes** some baloo config keys), on my system:
  
  balooctl: ~/.config/baloorc
  systemsettings/search: ~/.config/kcmshell5rc, ~/.config/systemsettingsrc
  
  I am not aware of any bad side effects having these garbage entries. baloo 
itself (or any of its library functions) newer read these keys from
  the mentioned files, only from ~/.config/baloofilerc.
  
  Adding cleanup code is of course possible, but this code:
  
  - has to be run at an appropriate time (each config read? write? session 
start?)
  - has to parse the config (at least systemsettingsrc is quite large)
  - is extra code which has to be maintained
  
  As this change is an improvement even without the cleanup, I would postpone 
the cleanup.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Nathaniel Graham]

ngraham added a comment.


  Looks good, but what's our transition plan? Does this need any special 
handling for people who already have old config files?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The KDE4 baloofilerc was only used by dolphin in the KDE4 migration
  phase and is no longer needed.
  
  In case a baloofilerc in the legacy location does not exist, the effect
  is even worse - the KConfig is instantiated with an empty path, and the
  config file name is derived from the application name. This leads to
  adding a "[General]" section in e.g. kcmshell5rc or systemsettingsrc.

TEST PLAN
  modify config using `balooctl config {add,rm}` or using SystemSettings
  -> .config/baloorc resp. .config/systemsettingsrc is no longer written,
  only .config/baloofilerc.

REPOSITORY
  R293 Baloo

BRANCH
  excludes

REVISION DETAIL
  https://phabricator.kde.org/D16392

AFFECTED FILES
  src/lib/indexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams