D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1b242697d27d: [KFileMetaData] Add helper for XML encoded 
Dublin Core metadata (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16488?vs=44373=44603

REVISION DETAIL
  https://phabricator.kde.org/D16488

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp
  src/extractors/dublincoreextractor.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich 
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns 
bruns added a comment.


  In D16488#351584 , @astippich 
wrote:
  
  > I guess you plan to convert the existing extractors to use this?
  
  
  Yes, thats the plan
  
  > The only concern I might have that now two iterations over the node are 
required when this is used in e.g. odfextractor, isn't it?
  
  The QDomDocument can be reused, so parsing is only done once. Iteration needs 
to be done twice, but this is only a minor issue as the metadata documents are 
**really** small (~10 nodes, 1kByte). For the office2007extractor it actually 
is a win, as it currently iterates the tree once per property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich 
astippich added a comment.


  I guess you plan to convert the existing extractors to use this?
  The only concern I might have that now two iterations over the node are 
required when this is used in e.g. odfextractor, isn't it?
  Btw, I don't think it's necessary to prepend KFileMetaData in the diff title, 
since the repository is only for KFileMetaData anyway.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-28 Thread Stefan Brüns 
bruns added a dependent revision: D16489: [KFileMetaData] Add extractor for 
generic XML and SVG.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-28 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Dublin Core metadata is used by several file formats, e.g. ODF,
  MS Office 2007 (Office XML) and SVG. Add a helper which can be
  used by the extractors.

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16488

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp
  src/extractors/dublincoreextractor.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams