D16612: Connect slots explicitly instead of using auto-connections

2020-07-13 Thread Alexander Volkov 
volkov abandoned this revision.
volkov added a comment.


  Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/76

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16612

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov 
volkov added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16612

To: volkov, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov 
volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Auto-connections is bad practice cause object renames break code
  and it can't be detected at compile time.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16612

AFFECTED FILES
  src/kcms/kio/cache.cpp
  src/kcms/kio/cache.h
  src/kcms/kio/kcookiesmanagement.cpp
  src/kcms/kio/kcookiesmanagement.h
  src/kcms/kio/kproxydlg.cpp
  src/kcms/kio/kproxydlg.h
  src/kcms/kio/useragentdlg.cpp
  src/kcms/kio/useragentdlg.h

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns