D16681: Updated with petroleum industry units

2018-11-05 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> unit.h:65
> +ElectricalResistanceCategory,
> +PermeabilityCategory
>  };

`/** @since 5.53 */` is needed here too.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: apol, ngraham, kde-frameworks-devel, michaelh, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  Great job, and nice first patch!
  
  Unfortunately, this doesn't compile:
  
-- Configuring done
CMake Error at src/CMakeLists.txt:32 (add_library):
  Cannot find source file:

permeability.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx
  
  Looks like the new permeability files  weren't added to the patch. You can 
use `git add  ` to do so, 
then `arc diff` to update the diff.

INLINE COMMENTS

> unit.h:333
> +MiliDarcy,
> +PermeabilitySquareMicrometer
>  };

Can you add `/** @since 5.53 */` for each of these new entries, following the 
pattern?

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto edited the summary of this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44901.
joaonetto added a comment.


  Updating D16681 <https://phabricator.kde.org/D16681>: Updated with petroleum 
industry units

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16681?vs=44899&id=44901

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
joaonetto requested review of this revision.

REVISION SUMMARY
  Added a new volume unity Oil Barrels and a new permeability class that 
handles Darcy and MiliDarcys.

REPOSITORY
  R292 KUnitConversion

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/length.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns