D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  This doesn't seem to actually work; after applying the patch; the new icon is 
not actually used with dark themes nor visible in Cuttlefish. Also the `dupe` 
test is now failing:
  
The following tests FAILED:
  4 - dupe (Failed)
Errors while running CTest
  
  Please make sure to run the unit tests with `ctest`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  App icons shouldn't have monochrome versions except for very limited 
exceptions like on the system tray. The issue being solved here is a general 
problem that we have when a dark icon is used with a dark color scheme. It's by 
no means limited to this icon (see also D17469 
), but we have some visual restrictions on 
resolving it since this is an app icon and we can't really redesign the icon  
like we can in D17469 .

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Emirald Mateli]

emateli added a comment.


  @anishgiri What is the advantage of using this outlined version of the 
Konsole icon(which we haven't seen in a light scheme yet) compared to using one 
of the monochrome icons already available?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 47242.
anishgiri added a comment.


  Fixed some lines around the corner

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=47239=47242

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 47239.
anishgiri added a comment.


  Changed the border color to #eff0f1 and 50% opacity

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=46959=47239

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  We had a big discussion in the VDG room and concluded that Konsole shouldn't 
even use this icon for its tabs by default 
(https://bugs.kde.org/show_bug.cgi?id=401864), which partially solves the 
problem.
  
  However I personally think it's still worthwhile to tweak this icon in the 
manner suggested here, as long as we turn down the outline intensity a bunch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Emirald Mateli]

emateli added a comment.


  Agree with @ndavis with respect to the icon. I would be in favor of using 
something similar (if not identical) to `dialog-scripts`. It's monochrome and 
works with dark and light backgrounds.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Noah Davis]

ndavis added a comment.


  Why are we using a color icon at such a small size? Wouldn't it make more 
sense to make a monochrome icon at that size?
  
  This change would also affect how the Konsole icon looks in other places such 
as the task manager. At 100% size, I don't see this looking good on the task 
manager.
  F6461489: Screenshot_20181207_102416.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  Great, the corners are now correct!
  
  For the outline let's try to use one of the Breeze colors, which you can see 
here: https://hig.kde.org/style/color/default.html
  
  What we typically do is choose one of the shades of gray, and make it 
partially transparent. That way it's not too bold and stark, but it still 
accomplishes the goal of separating the icon from what it's drawn on top of.
  
  @ndavis, do we have a consistent style for these translucent outlines? Should 
we come up with one?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 46959.
anishgiri edited the summary of this revision.
anishgiri added a comment.


  Corrected the bright corner issue

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=44931=46959

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Thanks for making those changes. Now we can see the icon, and also an issue 
that needs to be corrected. :) Notice how the corners look really 
bright--especially the bottom corners? That's a problem. I suspect what's 
happening is that the lines you drew to make the border are semi-transparent, 
but overlap one another at the corners, so the corners are mor opaque and 
therefore lighter. Either way, that "dots in the corner" effect must be fixed 
before this can land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri retitled this revision from "Patch For Bug 367696" to "Improve 
visibility for Konsole icon when using Breeze Dark".
anishgiri edited the summary of this revision.
anishgiri edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns