D16832: fix empty runner list after switching to new locale

2018-12-02 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Dead runners will surely be empty on the first load. You could still have had 
a locale change then.
  
  Also, now I'm re-reading it you're relying on locales to always have unique 
strings. It's perfectly plausible that spanish and italian could have 1 word 
matching. Or two locales having an untranslated value. As long as 1 value 
remains the same this workaround won't work.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

D16832: fix empty runner list after switching to new locale

2018-12-01 Thread Nick Shaforostoff 
shaforostoff added inline comments.

INLINE COMMENTS

> davidedmundson wrote in runnermanager.cpp:274
> what does deadRunners have to do with this?

if deadRunners is empty then there is no sense rerunning this method, and it 
even could cause endless recursion

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

D16832: fix empty runner list after switching to new locale

2018-11-14 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> runnermanager.cpp:274
>  
> +if (runners.isEmpty() && !deadRunners.isEmpty()) {
> +// protection against broken category data (e.g. from different 
> locale)

what does deadRunners have to do with this?

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

D16832: fix empty runner list after switching to new locale

2018-11-14 Thread Friedrich W. H. Kossebau 
kossebau resigned from this revision.
kossebau added a comment.


  No time and insight, sorry.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

D16832: fix empty runner list after switching to new locale

2018-11-13 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, kossebau, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis