D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  See if yo can shorten the title down to 50 characters and if not that, see if 
you can get it down to below 80.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  Unless someone has a final request, I think this is ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 updated this revision to Diff 45667.
trickyricky26 added a comment.


  - Switch arrow directions in ascending and descending variants

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45611=45667

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/sort.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/sort.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/sort.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/sort.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  In D16905#360938 , @trickyricky26 
wrote:
  
  > I am sure that in ascending, the lines get longer further down 
(representing larger file sizes etc.). The thing I am not quite sure about is 
the direction of the arrows.
  
  
  I would say make the direction of the arrows match the `view-sort-*-name` 
icons. This way existing users won't be confused.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 added a comment.


  I am sure that in ascending, the lines get longer further down (representing 
larger file sizes etc.). The thing I am not quite sure about is the direction 
of the arrows.
  
  In D16905#360524 , @cfeck wrote:
  
  > On lists that are sorted alphabetically A-Z (i.e. ascending), the first 
item is at the top, the last at the bottom. That's why user interfaces show an 
arrow pointing down; they show the direction of item "flow".
  
  
  According to this, on ascending (alphabetically a-z) sorted lists, the arrows 
points downwards to indicate the flow. 
  If this is correct, the new icons show the correct arrow direction, while the 
existing alphabetical sorting icons have this backwards.
  Perhaps they need to be changed in that regard, however I think this might be 
beyond the scope of this revision.
  
  Looking around the internet, quite some icons have arrows always pointing 
downwards, regardless of the sorting direction; I think this is the worst 
solution as the arrow does not provide any meaning.
  The La Capitaine icons have the same alphabetic icons as we do with the arrow 
pointing upwards in ascending versions; their generic sorting icons have the 
arrow pointing downwards in ascending versions.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  In D16905#360586 , @trickyricky26 
wrote:
  
  > - Fix naming of ascending and descending versions; make ascending versions 
less confusing; fix symlink sort-name
  >
  >   I have flipped the naming of the ascending and descending versions to be 
correct. The arrow in the ascending versions is now always at the top and does 
not cut off lines. The symbolic link `sort-name` was changed from 
`view-sort-ascending` to `view-sort-ascending-name`
  
  
  I hate to have you going back and forth, but are you (and anyone who 
suggested you do this) sure that this is right?
  F6428508: Screenshot_20181117_064300.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 updated this revision to Diff 45611.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  - Fix naming of ascending and descending versions; make ascending versions 
less confusing; fix symlink sort-name
  
  I have flipped the naming of the ascending and descending versions to be 
correct.
  The arrow in the ascending versions is now always at the top and does not cut 
off lines.
  The symbolic link `sort-name` was changed from `view-sort-ascending` to 
`view-sort-ascending-name`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45599=45611

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/sort.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/sort.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/sort.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/sort.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 added a comment.


  So you're saying the direction of the arrows is consisten with the current 
way, as long as the ascending and descending names are switched, correct?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Christoph Feck]

cfeck added a comment.


  On lists that are sorted alphabetically A-Z (i.e. ascending), the first item 
is at the top, the last at the bottom. That's why user interfaces show an arrow 
pointing down; they show the direction of item "flow".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Emirald Mateli]

emateli added a comment.


  @trickyricky26 I think we should stick to whatever conventions the KDE 
community has. I checked with Dolphin and the arrow goes up for descending and 
up for ascending, however the VDG makes these calls in the end.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  @emateli
  
  1. You're absolutely right about that, don't know how I missed this. With the 
correct naming, should the arrows still point to the end with longer lines?
  2. They are sorted, but some lines were shortened to make room for the arrow 
so it could stay in the bottom right. Earlier I had a design with the arrows 
moved to the top in the ascending version (I have edited the comment to have 
correct naming):
  
  In D16905#360495 , @trickyricky26 
wrote:
  
  > This is how the set looks with the arrows above the lines in the ascending 
versions:
  >
  > | size  | `view-sort` | `view-sort-descending` | 
`view-sort-ascending` |
  > | - | --- | -- | 
- |
  > | `16px`| F6427148: view-sort-16.svg.png 
   | F6427145: 
view-sort-16-ascending.svg.png    
   | F6427205: view-sort-16-descending-alt.svg.png 
 |
  > | `22px` and `24px` | F6427153: view-sort-22.svg.png 
   | F6427155: 
view-sort-22-ascending.svg.png    
   | F6427208: view-sort-22-descending-alt.svg.png 
 |
  > | `32px`| F6427177: view-sort-32.svg.png 
   | F6427162: 
view-sort-32-ascending.svg.png    
   | F6427210: view-sort-32-descending-alt.svg.png 
 |
  > |
  
  
  Do you feel these are less confusing?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Emirald Mateli]

emateli added a comment.


  1. Aren't the names in reverse? `view-sort-ascending` shows a list in 
descending order
  2. In `view-sort-descending` the items are not even sorted. Not sure how i 
feel about that.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 retitled this revision from "Add a generic sorting options icon" 
to "Add new generic sorting icons and rename existing alphabetic sorting icons 
to -name scheme".
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns