D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories
This revision was automatically updated to reflect the committed changes. Closed by commit R241:4f5b4fd218ca: [ioslaves/trash] Handle broken symlinks in deleted subdirectories (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17021?vs=45824=45845 REVISION DETAIL https://phabricator.kde.org/D17021 AFFECTED FILES src/ioslaves/trash/tests/testtrash.cpp src/ioslaves/trash/tests/testtrash.h src/ioslaves/trash/trashimpl.cpp To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17021 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories
davidedmundson edited the summary of this revision. davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17021 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The trash ioslave currently handles: - working symlinks at the toplevel - broken symlinks at the toplevel - working symlinks in subdirectories but broken symlinks in a subdirectory gets lost. This is because subdirs are populated from a QDir::listEntries in the subdirectory folder, which by default filters out broken symlinks. It's important to list them so that we we restore the directory as otherwise we lose data. The symlink could become non-dead once files are restored. BUG: 400990 TEST PLAN Relevant unit test REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17021 AFFECTED FILES src/ioslaves/trash/tests/testtrash.cpp src/ioslaves/trash/tests/testtrash.h src/ioslaves/trash/trashimpl.cpp To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns