D17051: Use correct variable type for returned value from read/sendfile
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8f926e459622: Use correct variable type for returned value from read/sendfile (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17051?vs=45890=45956 REVISION DETAIL https://phabricator.kde.org/D17051 AFFECTED FILES src/ioslaves/file/file_unix.cpp To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17051: Use correct variable type for returned value from read/sendfile
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17051 To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17051: Use correct variable type for returned value from read/sendfile
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY n stores the read/transferred bytes. This returns a ssize_t. We were casting to an int, which theoretically is a loss of data. In practice it isn't an issue as we only read a max of MAX_IPC_SIZE at a time, which would fit in an int. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17051 AFFECTED FILES src/ioslaves/file/file_unix.cpp To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
