D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page 
(authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17079?vs=45968=46277

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: vkrause, mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Volker Krause]

vkrause added a comment.


  In D17079#364308 , @mart wrote:
  
  > In D17079#364263 , @apol wrote:
  >
  > > In D17079#364163 , @ltoscano 
wrote:
  > >
  > > > kcoreaddons is tier1 just like kirigami. Why not create a new 
Frameworks, kirigami-addons (or another appropriate name), which would collect 
all the common UI items which depends on other frameworks? Basically the 
kxmlgui of Kirigami.
  > >
  > >
  > > I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  > >  That said, we'll need someone to register the KAbout* types somewhere 
too, but we can also rely on applications doing that as a first iteration.
  >
  >
  > one thing i'm a bit concerned is kirigami becomeing too much of a QML 
kdelibs monolith :p
  
  
  This came up when discussing date/time input widgets at Akademy as well. The 
idea there was also to have tier2 framework ("kirigami-addons") for this kind 
of stuff. Ie. higher-level controls that depend on Kirigami and possibly other 
tier1 frameworks, but unlike kdeclarative doesn't pull in QtWidgets as a 
dependency. So this wouldn't be just for the about page, but seems of much 
broader use.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: vkrause, mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#364263 , @apol wrote:
  
  > In D17079#364163 , @ltoscano 
wrote:
  >
  > > In D17079#364157 , @mart wrote:
  > >
  > > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  > >
  > >
  > > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  >
  >
  > I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  >  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.
  
  
  one thing i'm a bit concerned is kirigami becomeing too much of a QML kdelibs 
monolith :p

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#364163 , @ltoscano wrote:
  
  > In D17079#364157 , @mart wrote:
  >
  > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  >
  >
  > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  
  
  I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  In D17079#364157 , @mart wrote:
  
  > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  
  
  kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> DiscoverWindow.qml:76
>  }
> +TopLevelPageData {
> +id: aboutAction

can you try how does it look for this page to be pushed as a layer instead of 
the main PageRow?
would be like applicationWindow().pageStack.layers.push(thecomponentorurl)
it would end up more "modal"than using the main row.
I have no idea what would be better usability-wise, but is a thing could be 
tried (and then codified in the hig)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#363975 , @ngraham wrote:
  
  > Cool!
  >
  > For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.
  
  
  +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Basically what Nate said, this is a great idea :) Thinking that having this 
is already an improvement, but also perhaps that having it as a scrollable page 
would indeed feel more natural here rather than tabs... Thinking this seems 
like a good place to use the fact that Cards are good for not-quite-similar 
data, or am i off there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Nathaniel Graham]

ngraham added a comment.


  Cool!
  
  For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#363906 , @ltoscano wrote:
  
  > That's a great idea! Would it be possible:
  >
  > - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  
  
  Yes, I actually forgot to add it, it's basically a matter of replicating the 
authors bit but instead of calling .authors, we call .translators. Actually we 
should do the same for contributors too.
  
  > - to move this about page to some common kirigami-addons library?
  
  We would have to look into it, we don't want to have kirigami depend on 
kcoreaddons, but we can easily allow applications that don't use kcoreaddons to 
pass a json object that looks like KAboutData instance (duck typing!).
  Otherwise, we could also move it to kdeclarative or have kcoreaddons install 
it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  That's a great idea! Would it be possible:
  
  - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  - to move this about page to some common kirigami-addons library?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol edited the summary of this revision.
apol added a dependency: D17080: Make it possible to fallback to a different 
icon.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  WRT the gravatar bit, I'm not married to it, it's just a way to have this 
moving forward.
  
  I'll add some screenshots so you get an idea:
  
  F6435584: discover-about1.png 
  
  F6435585: discover-about2.png 
  
  F6435586: discover-about3.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 45968.
apol added a comment.


  Don't show the gravatar logo when not there

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17079?vs=45965=45968

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol edited the summary of this revision.
apol added a dependency: D17078: Make it possible to use 
KAboutData/License/Person from QML.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of using the one in xmlgui, create one that integrates properly in 
Kirigami/Discover.

TEST PLAN
  Used it, saw myself in it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart