D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Simon Peter]

probono added a comment.


  Thank you @kossebau, really nice to see this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: probono, TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[TheAssassin]

TheAssassin added a comment.


  Yep, it's really nice, thanks @kossebau!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the nice new icon!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e3266db59d2f: Add icons for 
application-vnd.appimage/x-iso9660-appimage (authored by kossebau).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17086?vs=46231=46359

REVISION DETAIL
  https://phabricator.kde.org/D17086

AFFECTED FILES
  icons/mimetypes/16/application-vnd.appimage.svg
  icons/mimetypes/16/application-x-iso9660-appimage.svg
  icons/mimetypes/22/application-vnd.appimage.svg
  icons/mimetypes/22/application-x-iso9660-appimage.svg
  icons/mimetypes/32/application-vnd.appimage.svg
  icons/mimetypes/32/application-x-iso9660-appimage.svg
  icons/mimetypes/64/application-vnd.appimage.svg
  icons/mimetypes/64/application-x-iso9660-appimage.svg

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for feedback/review :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[TheAssassin]

TheAssassin accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, that was it. Looks beautiful. Ship it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D17086#366120 , @ngraham wrote:
  
  > Looks great to me then!
  >
  > But how do I make this work? I compiled and installed the icon and verified 
that it's installed in the right place. But my AppImage isn't getting the new 
icon, not even after running `update-desktop-database`.
  >
  > F6441744: Weird.png 
  >
  > What am I doing wrong here?
  
  
  There might be the chance that the icon cache is not updated autpmagically 
after the icon installation. Try removing `.cache/icon-cache.kcache` before 
running a new instance of dolphin. Not sure if some index counter needs to be 
changed as welll for new icons, could not find some related change on new icon 
commits.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Nathaniel Graham]

ngraham added a comment.


  Looks great to me then!
  
  But how do I make this work? I compiled and installed the icon and verified 
that it's installed in the right place. But my AppImage isn't getting the new 
icon, not even after running `update-desktop-database`.
  
  F6441744: Weird.png 
  
  What am I doing wrong here?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D17086#366111 , @ngraham wrote:
  
  > Thanks, that looks great! As for the background color, I'd say it's okay to 
use a different shade of blue if it would better match the AppImage branding.
  
  
  For now I favor breeze palette usage, given the same IIRC is also done 
elsewhere with brand logo usage in Breeze icons.
  
  > Don't worry about participating in the style change discussion; if that 
ever bears any fruit, we'll change this icon as a part of it.
  
  Happy to have SVG editing skilled people take over, Inkscape is really in my 
way here :)
  
  > The images I posted came from the Cuttlefish app:
  >  F6441674: Cuttlefish.png 
  
  Ha, I noticed the very same time it be just screenshots snippets from 
cuttlefish when I looked at it during task-related usage :) Thanks for sharing 
the how.
  Might be a nice feature addition to have cuttlefish create such summary 
renderings as pixmaps itself to copy here & elsewhere, without the need to go 
via screenshot tool? Noted for fun hacks times...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Add icons for application-vnd.appimage" 
to "Add icons for application-vnd.appimage/x-iso9660-appimage".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns