D17114: [KUrlNavigator] Re-activate on mouse middle button click
This revision was automatically updated to reflect the committed changes. Closed by commit R241:fc5a98db98a8: [KUrlNavigator] Re-activate on mouse middle button click (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46049=46155 REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: thsurrel, #frameworks, elvisangelaccio, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
thsurrel added a comment. I tried that too, but it was not working for Dolphin. It did reactivate correctly the disabled split view, but the tab was not opened, I guess we were missing an event. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
elvisangelaccio accepted this revision. elvisangelaccio added a comment. We could have used `KUrlNavigator::mouseReleaseEvent()` where we already have the same check, but this is also fine. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This approach makes sense to me and works beautifully! REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
thsurrel updated this revision to Diff 46049. thsurrel added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46047=46049 BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: thsurrel, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
thsurrel edited the summary of this revision. thsurrel edited the test plan for this revision. thsurrel added reviewers: Frameworks, elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17114: [KUrlNavigator] Re-activate on mouse middle button click
thsurrel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: thsurrel Cc: kde-frameworks-devel, michaelh, ngraham, bruns
