D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-02 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of 
Latin1 characters, minor cleanups (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17282?vs=46628=46712

REVISION DETAIL
  https://phabricator.kde.org/D17282

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-02 Thread Stefan Brüns 
bruns added a comment.


  Because the original file is latin1, thus not decodable as utf8, so it has to 
be binary ...
  Stupid arc/phabricator

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-02 Thread Alexander Stippich 
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-02 Thread Alexander Stippich 
astippich added a comment.


  In D17282#369617 , @ngraham wrote:
  
  > Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file?
  
  
  I'm wondering the same.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-01 Thread Nathaniel Graham 
ngraham added a comment.


  Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

2018-12-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  ctest
  no functional changes

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams