D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9ed6507bce24: KateViewInternal: Rename getMouse/Cursor() 
= mouse/cursorPosition() to fit… (authored by loh.tar, committed by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17382?vs=46963=47183

REVISION DETAIL
  https://phabricator.kde.org/D17382

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewaccessible.h
  src/view/kateviewinternal.h
  src/vimode/inputmodemanager.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar added a comment.


  In D17382#372925 , @dhaumann wrote:
  
  > sorry for the delay :(
  
  
  What? No, it was pretty fast :-)
  But I have a couple of Sonnet stuff where no progress happens :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I think is an improvement - sorry for the delay :( will integrate tomorrow.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar added a comment.


  Without any special "Oh, that would be nice", I will stop now with further S
  
  - I have tried to clean up a little bit the two header files, but that's more 
difficult than thought
  - m_cursor => cursorPosition() is also not so easy
  - There was no comment regarding m_startPos => startPos()
  - m_mouse => mousePosition(), not investigated
  - Who can I bother regarding stuff on kate-editor.org ?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewaccessible.h
  src/view/kateviewinternal.h
  src/vimode/inputmodemanager.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann