D17619: fix for bug 401552

2018-12-17 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please change the summary to something more descriptive. A bug number is 
pretty opaque in itself.
  
  The patch itself looks good.
  
  I also don't understand "kdirmodeltest tests this already". It passes for me, 
without this change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: fix for bug 401552

2018-12-17 Thread Jaime Torres Amate 
jtamate edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: fix for bug 401552

2018-12-17 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 47731.
jtamate marked an inline comment as done.
jtamate retitled this revision from "Unit test and fix for bug 401552" to "fix 
for bug 401552".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  There is no need for a unit test, it is already in kdirmodeltest (but perhaps 
could be expanded in another patch).
  
  I've realized that it only modifies all paths of the subdirectories, and 
therefore if all the items of a sorted list change the same values, the order 
is preserved.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17619?vs=47666=47731

REVISION DETAIL
  https://phabricator.kde.org/D17619

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns