D17938: Add support for passing cursor information to KRun.

[Gleb Popov]

arrowd abandoned this revision.
arrowd added a comment.


  Right.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @arrowd I see you landed D18099 , so this 
can be discarded, right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D17938#386999 , @arrowd wrote:
  
  > In D17938#386985 , 
@elvisangelaccio wrote:
  >
  > > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. 
I'm not sure they make sense in the KRun API.
  >
  >
  > I'd say they are both filetype-specific and service-specific. But I haven't 
found any other approach.
  
  
  Did you see my comment in the bug report? 
https://bugs.kde.org/show_bug.cgi?id=398998#c5

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Albert Astals Cid]

aacid added a comment.


  Encode the information in the url?
  
  Also this change is binary incompatible, please see the wiki 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Gleb Popov]

arrowd added a comment.


  In D17938#386985 , 
@elvisangelaccio wrote:
  
  > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. 
I'm not sure they make sense in the KRun API.
  
  
  I'd say they are both filetype-specific and service-specific. But I haven't 
found any other approach.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm 
not sure they make sense in the KRun API.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Gleb Popov]

arrowd created this revision.
arrowd added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arrowd requested review of this revision.

REVISION SUMMARY
  This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998

TEST PLAN
  With another change to `kioclient5` (not submitted yet) running `kioclient5 
exec textfile:12:34` works fine.
  Corner cases also tested.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17938

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: arrowd, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns