D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  In D18163#398206 , @dhaumann wrote:
  
  > Is KateRenderer::setPrinterFriendly() only called in print preview mode? I 
think not.
  >
  > What is the bahavior currently when you print a page with another schema, 
and then print a page again? Does it always fallback to Printing without the 
patch, or does it remember the previous schema?
  
  
  Print -> Options -> Layout, the schema is always remembered with and without 
the patch.
  
  But I see your point, even though setting the schema in setPrinterFriendly() 
wouldn't change the behaviour for the File -> Print dialog anyway, it's 
probably much safer to just set the schema to Printing only in Print Preview 
and be done with it.
  
  I'll update the diff shortly.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Dominik Haumann]

dhaumann added a comment.


  Is KateRenderer::setPrinterFriendly() only called in print preview mode? I 
think not.
  
  What is the bahavior currently when you print a page with another schema, and 
then print a page again? Does it always fallback to Printing without the patch, 
or does it remember the previous schema?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  A gentle ping.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  @dhaumann: in the screenshot that's "file -> print"; the issue here is with 
"file -> print preview", where the extra options tabs (including "Layout") 
aren't added by ktexteditor. :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Looking at the printing pages, I can find the following, see screenshot. 
Please note the ComboBox where you can select a printing schema. In other 
words, this should not be hard-coded, I think it should be explicitly set 
somewhere to what's specified in this combobox. @ahmadsamir Can you have a look 
again?
  
  F6550687: image.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Milian Wolff]

mwolff accepted this revision as: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm, @cullmann @dhaumann? could the schema name be translated (I hope not)?

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added reviewers: KTextEditor, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a reviewer: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Otherwise the print preview dialog somehow gets the text color from the
  current default color scheme; also the user can't change the color scheme
  either from the print preview dialog or the "print" dialog launched from
  the preview dialog. All in all, this seems like a safe default.
  
  BUG: 391678
  FIXED-IN: 5.55.0

TEST PLAN
  - Change the default color scheme in kate to a dark one, e.g. Breeze dark
  - Open the print preview dialog, note that the text color is the one used in 
the breeze dark scheme, but the background color is still white
  
  Apply the diff, the print preview dialog will be using the Printing color 
scheme
  as expected.

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/render/katerenderer.cpp

To: ahmadsamir
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann