D18205: Test empty and zero gps data
This revision was automatically updated to reflect the committed changes. Closed by commit R286:15d8c42d8ce0: Test empty and zero gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49749=50078 REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES autotests/exiv2extractortest.cpp autotests/exiv2extractortest.h autotests/samplefiles/test_no_gps.jpg autotests/samplefiles/test_zero_gps.jpg To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: Test empty and zero gps data
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: Test empty and zero gps data
astippich updated this revision to Diff 49749. astippich added a comment. - update REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49377=49749 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES autotests/exiv2extractortest.cpp autotests/exiv2extractortest.h autotests/samplefiles/test_no_gps.jpg autotests/samplefiles/test_zero_gps.jpg To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: Test empty and zero gps data
bruns added inline comments. INLINE COMMENTS > astippich wrote in exiv2extractortest.cpp:65 > That's not possible, qFuzzyCompare does not handle this correctly with a too > small epsilon. It's probably because of the float->double conversion in the > extractor see comment in the other review REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: Test empty and zero gps data
astippich retitled this revision from "test empty and zero gps data" to "Test empty and zero gps data". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: test empty and zero gps data
astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractortest.cpp:65 > although only copied, I think it should be written like the other two: > `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);` That's not possible, qFuzzyCompare does not handle this correctly with a too small epsilon. It's probably because of the float->double conversion in the extractor REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: test empty and zero gps data
astippich updated this revision to Diff 49377. astippich added a comment. - move namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49316=49377 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES autotests/exiv2extractortest.cpp autotests/exiv2extractortest.h autotests/samplefiles/test_no_gps.jpg autotests/samplefiles/test_zero_gps.jpg To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: test empty and zero gps data
bruns added inline comments. INLINE COMMENTS > exiv2extractortest.cpp:62 > + > +using namespace KFileMetaData::Property; > +QCOMPARE(result.properties().value(PhotoGpsLatitude).toDouble(), 41.411); move this up, as it is not specific to this test case > exiv2extractortest.cpp:65 > +QCOMPARE(result.properties().value(PhotoGpsLongitude).toDouble(), 2.173); > +QVERIFY(qAbs(result.properties().value(PhotoGpsAltitude).toDouble() - > 12.2) < 0.0001); > + although only copied, I think it should be written like the other two: `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);` REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: test empty and zero gps data
astippich added a dependent revision: D18010: Allow zero altitude/longitude/latitude exiv gps data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18205: test empty and zero gps data
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Create a new test that more extensively checks gps data obtained via exiv. The test currently fails. REPOSITORY R286 KFileMetaData BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES autotests/exiv2extractortest.cpp autotests/exiv2extractortest.h autotests/samplefiles/test_no_gps.jpg autotests/samplefiles/test_zero_gps.jpg To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
