D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir added a comment.


  I've split the changes to the Loader in https://phabricator.kde.org/D18907.
  
  And will hopefully try to handle the Ui part in this current diff.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Display an error message if loading a dictionary fails

[loh tar]

loh.tar added a comment.


  My observations:
  
  - There is no hint when you activate auto spell check (yes, it's out of this 
scope)
  - Before showing the combobox by "Change Dictionary" the popup appears
  - The combobox shows then some other setting, here it was the first entry
  - When open the config dialog the new popup block the processing. So the 
expected dialog is only shown after user action
  
  F6576785: 1548859202.png 
  
  My suggestion:
  
  - For me are extra popups annoying. I would suggest to avoid them
  - Add some hint embedded to the Sonnet config dialog. IIRC I have seen in 
some config dialog a similar hint like these KTextEditor::Message, but I may 
wrong
  - Perhaps should the combobox shown an empty entry or an error hint instead 
of some (not expected) value
  - How about to emit the full message, not only the missed language? This way 
is no need to formulate everywhere an own error text
  
  Todo:
  
  - A patch to KTextEditor to show the hint as KTextEditor::Message when some 
spell check is requested

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir added a reviewer: loh.tar.
ahmadsamir added a subscriber: pino.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir updated this revision to Diff 50486.
ahmadsamir retitled this revision from "Don't fail if defaultLanguage 
dictionary can't be loaded" to "Display an error message if loading a 
dictionary fails".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a reviewer: loh.tar.
ahmadsamir removed a subscriber: pino.
ahmadsamir added a comment.


  Rework the patch:
  
  - so as not to change the config file without the user's intervention
  - core libs shouldn't depend on Gui bits

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18317?vs=49714=50486

BRANCH
  invalid-defaultLanguage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18317

AFFECTED FILES
  src/core/loader.cpp
  src/core/loader_p.h
  src/ui/dictionarycombobox.cpp
  src/ui/dictionarycombobox.h

To: ahmadsamir, sandsmark, loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, pino