D18730: Use breeze icons for search providers

2019-02-05 Thread Shubham 
shubham abandoned this revision.
shubham added a comment.


  Abandoned in favour of D18761 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Check out D18730 
  
  Then you can put `Icon=foo` in the respective search provider desktop file

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Shubham 
shubham added a comment.


  @broulik Adding icons to the .desktop files does not work, I tried.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a 
proper icon.
  
  https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps 
needs to have icons added

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Nathaniel Graham 
ngraham added a comment.


  In D18730#405089 , @shubham wrote:
  
  > @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.
  
  
  That's probably where we should fix this, then.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham added a comment.


  @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Nathaniel Graham 
ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender