D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag added a comment.


  In D18933#411966 , @davidedmundson 
wrote:
  
  > IMHO we should make frame() explicitly sent from the caller.
  
  
  Yeah, I'd prefer this way as well to be honest...
  
  > Hard to add retroactively in KF5 though :/
  
  So, it would be KF6 stuff, right?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[David Edmundson]

davidedmundson added a comment.


  > so we could send a diagonal scroll motion in one frame?
  
  We have this for a few things, such as clicking and moving.
  
  IMHO we should make frame() explicitly sent from the caller.
  I've hit this a few times (mostly wl_output) where KWayland tries to make 
things "easy" but in practice ends up making it harder to follow the protocol 
accurately.
  
  Hard to add retroactively in KF5 though :/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag added a subscriber: davidedmundson.
zzag added a comment.


  @davidedmundson Would it make sense to have something like
  
void pointerAxisV5(Qt::Orientations orientations, const QPointF ,
   const QPoint , PointerAxisSource source);
  
  so we could send a diagonal scroll motion in one frame?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag updated this revision to Diff 51659.
zzag added a comment.


  Add Unknown axis source.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18933?vs=51438=51659

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin
Cc: mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag retitled this revision from "Implement optional events from wl_pointer v5" 
to "Send optional events from wl_pointer v5".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns