D18965: Guard KCompressionDevice::open being called with no backend available

2019-02-15 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:3d5713ba3760: Guard KCompressionDevice::open being called 
with no backend available (authored by davidedmundson).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18965?vs=51529=51760

REVISION DETAIL
  https://phabricator.kde.org/D18965

AFFECTED FILES
  src/kcompressiondevice.cpp

To: davidedmundson, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18965: Guard KCompressionDevice::open being called with no backend available

2019-02-12 Thread Nathaniel Graham 
ngraham added reviewers: Plasma, Frameworks.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fixes the crash for me and makes logical sense.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18965

To: davidedmundson, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18965: Guard KCompressionDevice::open being called with no backend available

2019-02-12 Thread David Edmundson 
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If KArchive is built without support for a compression type, such as
  bzip2, d->filter ends up as null.
  
  It is then used in the open call and will crash.
  
  Other calls can still crash, but they shouldn't be being called if open
  fails.
  
  BUG: 404240

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18965

AFFECTED FILES
  src/kcompressiondevice.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns