D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein added a comment.


  LGTM, thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty updated this revision to Diff 51890.
rooty added a comment.


  Use "-gamepad" instead

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19030?vs=51759=51890

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-gamepad.svg
  icons-dark/devices/22/input-gamepad.svg
  icons-dark/devices/64/input-gamepad.svg
  icons-dark/devices/symbolic/input-gamepad-symbolic.svg
  icons/devices/16/input-gamepad.svg
  icons/devices/22/input-gamepad.svg
  icons/devices/64/input-gamepad.svg
  icons/devices/symbolic/input-gamepad-symbolic.svg

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  @hein thoughts? I'm not keen on deleting that icon, God only knows what 
application might be using it :D

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  Oh never mind, just ignore me then. Sounds like y'all had everything under 
control before I started confusing everyone. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#413778 , @ngraham wrote:
  
  > I think the idea was that we only needed `input-games` and 
`input-games-symbolic`, and not also `input-gaming` and 
`input-gaming-symbolic`. Right?
  
  
  There already is a 64 px icon called input-gaming in master. What do I do 
with that icon, rename it (remove then add?)?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  I think the idea was that we only needed `input-games` and 
`input-games-symbolic`, and not also `input-gaming` and 
`input-gaming-symbolic`. Right?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Noah Davis]

ndavis added a comment.


  In D19030#412778 , @ngraham wrote:
  
  > Now we don't need `input-gaming` anymore. :)
  
  
  What happens if an application asks for a 22px `input-gaming` icon and not 
`input-gaming-symbolic`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#412778 , @ngraham wrote:
  
  > Now we don't need `input-gaming` anymore. :)
  
  
  @hein put the "too" in parentheses :D, I was erring on the side of caution
  
  But what do I do to the 64 px version? Rename it to input-games? It's not a 
symlink

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  Now we don't need `input-gaming` anymore. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty updated this revision to Diff 51759.
rooty added a comment.


  Add input-games and input-games-symbolic

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19030?vs=51732=51759

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-games.svg
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-games.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/64/input-games.svg
  icons-dark/devices/symbolic/input-games-symbolic.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-games.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-games.svg
  icons/devices/22/input-gaming.svg
  icons/devices/64/input-games.svg
  icons/devices/symbolic/input-games-symbolic.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  +1 on `input games` and `input-games-symbolic`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#412562 , @hein wrote:
  
  > Could this maybe be input-games-symbolic (too)? Because I want a monochrome 
version always (my app recolors icons using the Kirigami feature, and that only 
works with monochrome icons).
  
  
  In addition to or instead of -gaming?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein added a comment.


  Could this maybe be input-games-symbolic (too)? Because I want a monochrome 
version always (my app recolors icons using the Kirigami feature, and that only 
works with monochrome icons).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added reviewers: hein, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-gaming.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns