D19088: Use propertymap to store properties in Baloo::Result

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4f131981493b: Use propertymap to store properties in 
Baloo::Result (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19088?vs=51887=67815#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19088?vs=51887=67815

REVISION DETAIL
  https://phabricator.kde.org/D19088

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/result.cpp
  src/file/extractor/result.h
  src/lib/CMakeLists.txt
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19088: Use propertymap to store properties in Baloo::Result

[Alexander Stippich]

astippich added a comment.


  ping @bruns
  are you going to land this series?

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19088: Use propertymap to store properties in Baloo::Result

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19088: Use propertymap to store properties in Baloo::Result

[Alexander Stippich]

astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> file.cpp:121
>  const QJsonDocument jdoc = QJsonDocument::fromJson(arr);
> -const QVariantMap varMap = jdoc.object().toVariantMap();
> -d->propertyMap = KFileMetaData::toPropertyMap(varMap);
> +d->propertyMap = Baloo::jsonToPropertyMap(jdoc.object());
>  

We are already using Baloo namespace here.

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19088: Use propertymap to store properties in Baloo::Result

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Storing properties directly in a PropertyMap is more efficient (no
  temporary conversion of property number to string, lookup with integer
  key), and it also guarantees to have the same data as the extractor used
  by BalooWigets, as long as (de)serialization to the Json format stored in
  the DB is lossless.
  
  Depends on D19087 

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/result.cpp
  src/file/extractor/result.h
  src/lib/CMakeLists.txt
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams