D19598: DocumentPrivate: Make auto bracket slightly smarter

2019-03-07 Thread loh tar 
loh.tar updated this revision to Diff 53412.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - *hmpf* forgot may last cleanup change

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19598?vs=53410=53412

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Make auto bracket slightly smarter

2019-03-07 Thread loh tar 
loh.tar updated this revision to Diff 53410.
loh.tar added reviewers: cullmann, mwolff.
loh.tar added a comment.


  - Add KateDocumentTest::testAutoBrackets
  
  Just a note to the current RegEx solution:
  It's done as you see in a slightly redundant dumb way. Perhaps is a special 
function without regex faster?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19598?vs=53375=53410

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Make auto bracket slightly smarter

2019-03-07 Thread loh tar 
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ..in handling of quotes
  
  - Skip auto quotes when these looks already balanced
  - Improve readability, const correctness
  - const QChar as value, not reference
  
  BUG:405089
  FIXED-IN: 5.56

TEST PLAN
Try to type this in a C++ file:
('\'') => ended up in something like: ('\''')

Try to add afterwarnds double quotes to some word in a text, without to 
select the word:
foo "bar" haz => ended up in something like: foo "bar"" haz
  
  - Autotest looks good
  - Contains partial code from unloved D17693 
 which is here only added to became it in. 
See latter two Summary notes
  - Is the fix-in number right?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann