D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428074 , @bruns wrote:
  
  > Do not create a new transaction per file, thats costly.
  
  
  Still less expensive than single transaction for 1k files

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh updated this revision to Diff 53549.
davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added a comment.


  Don't create transaction for every file

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19644?vs=53537=53549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Do not create a new transaction per file, thats costly.

INLINE COMMENTS

> main.cpp:222
>  out << "Skipping: " << url << " Reason: Already scheduled 
> for indexing\n";
>  continue;
>  }

You are discarding the write transaction here withouth calling commit() or 
abort()

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428047 , @bruns wrote:
  
  > A transaction can not be split up, thats the reason it is a transaction ...
  
  
  It can and they must be split in a lot smaller transactions. Currently 
sometimes baloo uses way too big transactions which causes memory usage to 
spike.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added reviewers: dhaumann, bruns, ngraham.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Stefan Brüns]

bruns added a comment.


  A transaction can not be split up, thats the reason it is a transaction ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davispuh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams