D19672: [knewstuff] make it compile without foreach
This revision was automatically updated to reflect the committed changes. Closed by commit R304:20870ce8cc79: [knewstuff] make it compile without foreach (authored by mlaurent). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19672?vs=53633=53650 REVISION DETAIL https://phabricator.kde.org/D19672 AFFECTED FILES CMakeLists.txt autotests/kmoretools/kmoretoolstest.cpp autotests/kmoretools/kmoretoolstest2.cpp src/attica/atticaprovider.cpp src/core/cache.cpp src/core/engine.cpp src/core/entryinternal.cpp src/core/installation.cpp src/downloadwidget.cpp src/kmoretools/kmoretools.cpp src/kmoretools/kmoretools_p.h src/kmoretools/kmoretoolsconfigdialog_p.cpp src/kmoretools/kmoretoolsmenufactory.cpp src/kmoretools/kmoretoolspresets.cpp src/qtquick/quickitemsmodel.cpp src/staticxml/staticxmlprovider.cpp src/ui/entrydetailsdialog.cpp src/ui/itemsgridviewdelegate.cpp src/ui/itemsviewdelegate.cpp src/upload/atticahelper.cpp src/uploaddialog.cpp tests/khotnewstuff.cpp tests/khotnewstuff_test.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: mlaurent, dfaure, apol, leinir Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns
D19672: [knewstuff] make it compile without foreach
leinir accepted this revision. leinir added a comment. Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19672 To: mlaurent, dfaure, apol, leinir Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns
D19672: [knewstuff] make it compile without foreach
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19672 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19672: [knewstuff] make it compile without foreach
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19672 AFFECTED FILES CMakeLists.txt autotests/kmoretools/kmoretoolstest.cpp autotests/kmoretools/kmoretoolstest2.cpp src/attica/atticaprovider.cpp src/core/cache.cpp src/core/engine.cpp src/core/entryinternal.cpp src/core/installation.cpp src/downloadwidget.cpp src/kmoretools/kmoretools.cpp src/kmoretools/kmoretools_p.h src/kmoretools/kmoretoolsconfigdialog_p.cpp src/kmoretools/kmoretoolsmenufactory.cpp src/kmoretools/kmoretoolspresets.cpp src/qtquick/quickitemsmodel.cpp src/staticxml/staticxmlprovider.cpp src/ui/entrydetailsdialog.cpp src/ui/itemsgridviewdelegate.cpp src/ui/itemsviewdelegate.cpp src/upload/atticahelper.cpp src/uploaddialog.cpp tests/khotnewstuff.cpp tests/khotnewstuff_test.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
