D19986: Install .desktop file for kded5
dfaure added a comment. OK, changed in https://commits.kde.org/kded/b733c88e2d70db854cf99466ef52c9a3f9db118e REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
rjvbb added a comment. It seems to me there's a way to tell the translators that a string shouldn't be translated. Why not use that, or put a name that doesn't require translation (like `name=kded5.desktop`)? NB: I replaced "SystemService" with "Service" in my copy, and haven't seen that other warning at all. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
davidedmundson added a comment. Sorry, I missed your message. INLINE COMMENTS > dfaure wrote in org.kde.kded5.desktop:4 > What does SystemService mean? > > I'm seeing a warning from the kservice framework: > The desktop entry file "/share/applications/org.kde.kded5.desktop" > has Type= "SystemService" instead of "Application" or "Service". > > Would it be ok to use Service instead, or does SystemService have a special > meaning on wayland? > Would it be ok to use Service instead, or does SystemService have a special > meaning on wayland? From the POV of the bug we're fixing, sure. SystemService means nothing, it's an invalid type. The reason I used an invalid type is to suppress a different warning about not having a name/comment, and I didn't want to make translators do any work for something that is never shown. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
rjvbb added inline comments. INLINE COMMENTS > dfaure wrote in org.kde.kded5.desktop:4 > What does SystemService mean? > > I'm seeing a warning from the kservice framework: > The desktop entry file "/share/applications/org.kde.kded5.desktop" > has Type= "SystemService" instead of "Application" or "Service". > > Would it be ok to use Service instead, or does SystemService have a special > meaning on wayland? I'm seeing this too whenever I start an application (from a commandline) after installing something and before the automatic kbuildsycoca5 invocation had a chance to occur. Not very happy about that... REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
dfaure added inline comments. INLINE COMMENTS > org.kde.kded5.desktop:4 > +#it's here mostly so wayland can get an icon on popups > +Type=SystemService > +Icon=kde-frameworks What does SystemService mean? I'm seeing a warning from the kservice framework: The desktop entry file "/share/applications/org.kde.kded5.desktop" has Type= "SystemService" instead of "Application" or "Service". Would it be ok to use Service instead, or does SystemService have a special meaning on wayland? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
This revision was automatically updated to reflect the committed changes. Closed by commit R297:496b785f2218: Install .desktop file for kded5 (authored by davidedmundson). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19986?vs=54588&id=55680 REVISION DETAIL https://phabricator.kde.org/D19986 AFFECTED FILES CMakeLists.txt org.kde.kded5.desktop To: davidedmundson, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19986: Install .desktop file for kded5
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is useful as on wayland setting a path to a desktop file is mandatory for icons on any windows. Qt sets the app_id to org.kde.kde5 but this desktop file doesn't exist. We do a similar fix in plasmashell and other services that don't really map to the traditional application pattern. I set the type to something other than Application so we don't have to put an Exec line though it wouldn't really matter as it's hidden anway. BUG: 387556 TEST PLAN Opened a vault Got an icon REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D19986 AFFECTED FILES CMakeLists.txt org.kde.kded5.desktop To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
