D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-04-07 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c244729b6771: Enable glGetGraphicsResetStatus support by 
default on Qt = 5.13 (authored by davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20087?vs=54973=55682

REVISION DETAIL
  https://phabricator.kde.org/D20087

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: davidedmundson, apol
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-03-29 Thread Nathaniel Graham 
ngraham added a comment.


  Given the testing already done by users, yeah, I think this is safe to land. 
+1

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20087

To: davidedmundson, apol
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-03-28 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  ¯\_(ツ)_/¯

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20087

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-03-28 Thread David Edmundson 
davidedmundson added a comment.


  It's autogenerated, so non-trivial

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20087

To: davidedmundson
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-03-28 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> qtquicksettings.cpp:47
> +if (s.graphicsResetNotifications() ||
> +QLibraryInfo::version() >= QVersionNumber(5, 13, 0)) {
>  format.setOption(QSurfaceFormat::ResetNotification);

Shouldn't this check be in graphicsResetNotifications then?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20087

To: davidedmundson
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

2019-03-28 Thread David Edmundson 
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I added support in Qt for handling Nvidia's glGetGraphicsResetStatus
  flag, which reports when it has lost it's context and the visual state
  needs refreshing.
  
  As it required some changes in various other parts of Qt and Plasma this
  was opt-in behind a QSurfaceFormat flag which I exposed to Plasma users
  via a config option. Since Qt5.12.2 everything seems to work nicely.
  
  This patch enables support on Qt >= 5.13 to play safe.
  
  BUG: 364766

TEST PLAN
  Feedback from wide test audience on the bug report.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20087

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns