D20172: use plasma icon as icon for plasma notification category

2019-04-01 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:8ce99b1637ef: use plasma icon as icon for plasma 
notification category (authored by sitter).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20172?vs=55203&id=55212

REVISION DETAIL
  https://phabricator.kde.org/D20172

AFFECTED FILES
  plasma_workspace.notifyrc

To: sitter, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns


D20172: use plasma icon as icon for plasma notification category

2019-04-01 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Oh, on a related note, I actually do wonder if we should symlink 
start-here-kde in breeze to start-here-kde-plasma and use that instead to 
differentiate? As per the spec on !breeze icon themes start-here-kde-plasma 
would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So 
it's just as portable but less ambiguous perhaps.
  
  We should.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns


D20172: use plasma icon as icon for plasma notification category

2019-04-01 Thread Harald Sitter
sitter added a comment.


  Oh, on a related note, I actually do wonder if we should symlink 
start-here-kde in breeze to start-here-kde-plasma and use that instead to 
differentiate? As per the spec on !breeze icon themes start-here-kde-plasma 
would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So 
it's just as portable but less ambiguous perhaps.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20172: use plasma icon as icon for plasma notification category

2019-04-01 Thread Harald Sitter
sitter retitled this revision from "use the plasma icon as plasma icon" to "use 
plasma icon as icon for plasma notification category".

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns