D20526: Fix extracting of some properties to match what was written
This revision was automatically updated to reflect the committed changes. Closed by commit R286:a51e96979b4e: Fix extracting of some properties to match what was written (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=60842=61242 REVISION DETAIL https://phabricator.kde.org/D20526 AFFECTED FILES autotests/taglibwritertest.cpp autotests/taglibwritertest.h src/extractors/taglibextractor.cpp To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich added a comment. thanks REPOSITORY R286 KFileMetaData BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich added a comment. friendly ping, I would like to get this into 5.60 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:356 > is this always just one value, or a list as well? as far as I know, asf only allows single entry tags, so just a single value REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich updated this revision to Diff 60842. astippich marked an inline comment as done. astippich added a comment. - add trimmed(), adjust test - fileExtension REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=60334=60842 BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 AFFECTED FILES autotests/taglibwritertest.cpp autotests/taglibwritertest.h src/extractors/taglibextractor.cpp To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
bruns added inline comments.
INLINE COMMENTS
> taglibwritertest.cpp:556
> +
> +data.add(Property::Artist, QStringLiteral("Artist1 feat Artist2"));
> +data.add(Property::AlbumArtist, QStringLiteral("Artist1 feat. Artist2"));
const map properties = { {Artist, "Artist", ...};
for (property : properties) {
data.add(...);
}
write(data);
exxtractResult(...);
for (property: properties) {
QCOMPARE(...);
}
> taglibwritertest.cpp:578
> +{
> +QTest::addColumn("fileType");
> +QTest::addColumn("mimeType");
fileExtension
> taglibextractor.cpp:171
> for (const auto& artist : artists) {
> -result->add(Property::Artist, artist);
> +result->add(Property::Artist, TStringToQString(artist));
> }
There is a small mismatch between this one (and all others below) and e.g.
"LYRICS" above - one uses `trimmed()`, the other does not.
IMHO, all properties should be trimmed (though we risk not being
roundtrip-save).
> taglibextractor.cpp:356
> lstASF = asfTags->attribute("Author");
> if (!lstASF.isEmpty()) {
> const auto attribute = lstASF.front();
is this always just one value, or a list as well?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D20526: Fix extracting of some properties to match what was written
astippich retitled this revision from "fix extracting of some properties to match what was writen" to "Fix extracting of some properties to match what was written". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
