D20570: [FrameSvgItem] Respect smooth property
This revision was automatically updated to reflect the committed changes. Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56289=56290 REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp To: broulik, #plasma, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
D20570: [FrameSvgItem] Respect smooth property
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> framesvgitem.cpp:95
> {
> +setFiltering(filtering);
> m_lastParent->appendChildNode(this);
could have here
frameSvg->smooth() ? QSGTexture::Linear : QSGTexture::Nearest;
to make the patch smaller?
anyways, i'm fine with either.. this one calculates the sace only once so may
be arguued to be better
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D20570
To: broulik, #plasma, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
D20570: [FrameSvgItem] Respect smooth property
broulik updated this revision to Diff 56289. broulik added a comment. - Also update corner nodes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56288=56289 REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp To: broulik, #plasma Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
D20570: [FrameSvgItem] Respect smooth property
mart added a comment. FrameItemNode needs the same REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
D20570: [FrameSvgItem] Respect smooth property
broulik planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D20570: [FrameSvgItem] Respect smooth property
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Set `smooth: true`, rotated it, didn't look jagged anymore REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
