D20655: Use generated DBus interface

[Stefan Brüns]

bruns added a comment.


  In D20655#647806 , @davidedmundson 
wrote:
  
  > We copy udisks xml already. I don't think it ends up any better. Otherwise 
we have a compile time dep on a runtime plugin, which inevitably means we need 
to make it optional which only introduces more real-world bugs. It also means 
future devs know what we were compiled against.
  >
  > Marking as requesting changes for the extra include, but personally I think 
it's generally good to go.
  
  
  We are also already copying part of the interface specification. After all, 
`indexOfSignal("DeviceAdded(QDBusObjectPath)")` is the same as the 
corresponding code generated by dbusxml2cpp.
  
  Two more change requests:
  
  - Please mention support for the deprecated `DeviceAdded(string)` (upower < 
0.99) is removed
  - Please wrap long lines in the summary etc.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D20655: Use generated DBus interface

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  We copy udisks xml already. I don't think it ends up any better. Otherwise we 
have a compile time dep on a runtime plugin, which inevitably means we need to 
make it optional which only introduces more real-world bugs. It also means 
future devs know what we were compiled against.
  
  Marking as requesting changes for the extra include, but personally I think 
it's generally good to go.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D20655: Use generated DBus interface

[Aleix Pol Gonzalez]

apol added a comment.


  UPower already installs the xml files. Wouldn't it be better to use the 
installed xml instead of providing our own?

INLINE COMMENTS

> upowerdevice.cpp:35
>  
> +#include 
> +

unneeded?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20655: Use generated DBus interface

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids introspection calls when creating the manager or devices.
  Also drop codepath for old UPower, according to their git, the interface 
hasn't changed since 2015 (that's as far back as the history went, I didn't go 
any further) so I think it's safe to assume everyone uses an upower version 
that has this.

TEST PLAN
  Unless that special "last non-systemd version" some distros use is older than 
this?
  
  - Plugged in my mouse, showed up, plugged it out, disappeared
  - I shall test with my laptop whether the battery property changes are 
detected properly

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

AFFECTED FILES
  src/solid/devices/backends/upower/CMakeLists.txt
  src/solid/devices/backends/upower/dbus/org.freedesktop.UPower.Device.xml
  src/solid/devices/backends/upower/dbus/org.freedesktop.UPower.xml
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/backends/upower/upowerdevice.h
  src/solid/devices/backends/upower/upowermanager.cpp
  src/solid/devices/backends/upower/upowermanager.h

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns