D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-13 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:b70018ee4b3e: [JobDialog] Also signal cancellation when 
window is closed by the user (authored by broulik).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21119?vs=57849=57980

REVISION DETAIL
  https://phabricator.kde.org/D21119

AFFECTED FILES
  src/widgets/JobDialog.qml

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21119

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This signal is emitted when the user tries to close the window manually, not 
when doing it programmatically.

TEST PLAN
  Asked it to share to kde connect, closed the window, got a cancellation 
signalled
  Asked it to share to kde connect, accepted task, task succeeded

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21119

AFFECTED FILES
  src/widgets/JobDialog.qml

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns