D21179: FrameSvgItem: emit maskChanged always from doUpdate()
This revision was automatically updated to reflect the committed changes. Closed by commit R242:084ba0f886d1: FrameSvgItem: emit maskChanged always from doUpdate() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21179?vs=57973=58037 REVISION DETAIL https://phabricator.kde.org/D21179 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D21179: FrameSvgItem: emit maskChanged always from doUpdate()
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvgitemmoreemitmaskchanged REVISION DETAIL https://phabricator.kde.org/D21179 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D21179: FrameSvgItem: emit maskChanged always from doUpdate()
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY In that method we can assue a high chance that the mask is also affected. Instead of adding complicated additional code to track if the mask really changed, we rely on the cached value from FrameSvg. This method is not too often called in a Plasma session, so that further optimization work to avoid unneccesary emits seems not yet worth it. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvgitemmoreemitmaskchanged REVISION DETAIL https://phabricator.kde.org/D21179 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp To: kossebau, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
