D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-12-14 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:c97f0b2a3076: Ensure mounted nfs filesystems matches 
their fstab declared counterpart (authored by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21204?vs=67981&id=71566#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=67981&id=71566

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-12-12 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-12-12 Thread Stefan Brüns 
bruns added a comment.


  please remove the 2 comments.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-12-12 Thread Stefan Brüns 
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> fstabhandling.cpp:246
> +if (deviceName.endsWith(QLatin1Char('/'))) {
> +// remove trailing slash
> +deviceName.chop(1);

This comment is stating the obvious ...

> fstabhandling.cpp:249
> +} else {
> +// add a trailing slash
> +deviceName.append(QLatin1Char('/'));

dito

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-10-15 Thread Méven Car 
meven updated this revision to Diff 67981.
meven marked an inline comment as done.
meven added a comment.


  Avoid else after continue;

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=65955&id=67981

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-10-15 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-13 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:240
> +continue;
> +} else {
> +// deviceName will or won't end with / depending if device ended 
> with one

No need to put this in `.. else {` after `continue`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-13 Thread Méven Car 
meven updated this revision to Diff 65955.
meven added a comment.


  Rebase on master, review feedback

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=62027&id=65955

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-13 Thread Méven Car 
meven marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-12 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fstabhandling.cpp:236
> +auto device = it.key();
> +QString deviceName = device;
> +if (deviceName.endsWith(QLatin1Char('/'))) {

You should check for `devices.contains(deviceName)` here and `continue`, avoids 
detaching deviceName when not necessary.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-12 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Let's get this in soon. We have plenty of time before Frameworks 5.63.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-09-12 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-08-13 Thread Nathaniel Graham 
ngraham added a comment.


  @bruns ping! :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-19 Thread Nathaniel Graham 
ngraham added a comment.


  @bruns, is this good to go now?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-19 Thread Méven Car 
meven updated this revision to Diff 62027.
meven added a comment.


  Remove dead code

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=60913&id=62027

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-01 Thread Méven Car 
meven marked 4 inline comments as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-01 Thread Méven Car 
meven marked 2 inline comments as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-01 Thread Méven Car 
meven updated this revision to Diff 60913.
meven added a comment.


  Use an iterator to loop over globalFstabCache->m_fstabCache

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=60855&id=60913

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-01 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:227
> +QStringList devices = globalFstabCache->m_mtabCache.keys();
> +const QStringList fstabDevices = globalFstabCache->m_fstabCache.keys();
> +

Don't create a temporary `keys()` list just to iterate it. Use a loop like

  for (auto it = globalFstabCache->m_fstabCache.constBegin(),
   end = globalFstabCache->m_fstabCache.constEnd();
   it != end; ++it) {
  QString deviceName = it.key();
  ...
  }

> fstabhandling.cpp:234
> +QString deviceName = device;
> +if (deviceName.endsWith((QLatin1Char('/' {
> +deviceName.chop(1);

Excess parentheses

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-01 Thread Méven Car 
meven retitled this revision from "Ensure mounted mounted nfs filesystems 
matches their fstab declared counterpart" to "Ensure mounted nfs filesystems 
matches their fstab declared counterpart".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, 
LeGast00n, michaelh