D21402: Avoid double overwrite check

[Christoph Cullmann]

cullmann added a comment.


  Hmm, doesn't this only rely on the behavior of QFileDialog::getSaveFileUrl?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: kossebau, apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, 
demsking, cullmann, sars

D21402: Avoid double overwrite check

[Friedrich W. H. Kossebau]

kossebau added a comment.


  As wm4 just pointed out on irc, this might need fallback code for older 
versions of KF, no? Currently Kate has KF5_DEP_VERSION 5.40, so you might 
either want to bump that min dep to match the version of ktexteditor which does 
the check itself, or add some (runtime/buildtime) check for the KF version.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: kossebau, apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, 
demsking, cullmann, sars

D21402: Avoid double overwrite check

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R40:09053597e699: Avoid double overwrite check (authored by 
meven).

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21402?vs=58647=58709

REVISION DETAIL
  https://phabricator.kde.org/D21402

AFFECTED FILES
  kate/katesavemodifieddialog.cpp

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21402: Avoid double overwrite check

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, then lets do this.

REPOSITORY
  R40 Kate

BRANCH
  native-check

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21402: Avoid double overwrite check

[Aleix Pol Gonzalez]

apol added a comment.


  That should work on every platform. In fact, it would be a bug if any 
platform didn't do it.
  
  https://doc.qt.io/qt-5/qfiledialog.html#Option-enum
  See QFileDialog::DontConfirmOverwrite.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21402: Avoid double overwrite check

[Dominik Haumann]

dhaumann added a comment.


  Is this correct in all cases? Do we support KIO here? Does that depend on 
platform integration, i.e. gnome or Windows?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars

D21402: Avoid double overwrite check

[Méven Car]

meven created this revision.
meven added reviewers: Kate, Frameworks, cullmann.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
meven requested review of this revision.

REVISION SUMMARY
  QFileDialog has by default an overwrite check, avoid the second one done by 
kate.
  
  Related to D21401 

REPOSITORY
  R40 Kate

BRANCH
  native-check

REVISION DETAIL
  https://phabricator.kde.org/D21402

AFFECTED FILES
  kate/katesavemodifieddialog.cpp

To: meven, #kate, #frameworks, cullmann
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann