D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-24 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 64465.
leinir added a comment.


  - Use the image's Ready status, rather than just the url availability

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=64426=64465

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-23 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 64426.
leinir added a comment.


  - Switch to a slightly different avatar display method
  - Rejig the lamdba slightly, with less indirection (and more working)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=64413=64426

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-23 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 64413.
leinir added a comment.


  - Work up the NewStuffItem layout a touch...
  - Less explicit layouting (and more QtLayouts)
  - Re-enable use of the (now more usable) score from the comments model

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=63107=64413

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-05 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 63107.
leinir added a comment.


  - Use typed animations instead of the inefficient PropertyAnimation

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62850=63107

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-31 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 62850.
leinir added a comment.


  - Parent the QuickQuestionAsker to qApp
  - Add in a QuestionAsker on NewStuffList

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62846=62850

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-31 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 62846.
leinir added a comment.


  - Fix up the NewStuffItem installer busy indicator a bit

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62844=62846

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-31 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 62844.
leinir added a comment.


  - Add in a getter for category displaynames
  - Add category/filter/sort dropdowns to NewStuffList
  - A bit of minor prettification for NewStuffItem

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62785=62844

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-30 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 62785.
leinir added a comment.


  - Actually request a downloaditem in NewStuffItem when install/updating

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62049=62785

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-19 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 62049.
leinir added a comment.


  - Refactor the naming of components etc a touch (and hide private bits)
  - Fix a few bits of stray naming in the docs

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61905=62049

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-17 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61905.
leinir added a comment.


  - Don't use outdated code (e.g. the Kirigami Label component)
  - Update NewStuffList to the new model API
  - Explicit operator= implementations (for less warnings)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61638=61905

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-12 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61638.
leinir added a comment.


  - A small spacer item for the entry details page
  - Documentation++
  - Show a passive notification in the dialog when messages are posted

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61500=61638

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-10 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61500.
leinir added a comment.


  - Add a downloaditemssheet to the entry details page

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61341=61500

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-08 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61341.
leinir added a comment.


  - Put the NewStuff.Author component to use on the details page as well

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61340=61341

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-08 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61340.
leinir added a comment.


  - Add the user ID to the author class
  - Expose the entry author id through the qtquick item model
  - Rename the entryAuthor property to entryAuthorId, as that's what it is
  - Add a bit more info to the author
  - Add a copy ctor to Author
  - Make sure we check the right things, and format the author correctly

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61331=61340

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-08 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61331.
leinir added a comment.


  Thanks kbroulik!
  
  - allowedByKiosk should be a CONSTANT property, as it's... constant
  - Postpone engine initialisation until Button is clicked

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61065=61331

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-03 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 61065.
leinir added a comment.


  - Add profile page to the author classes
  - Add a spacer item to the CommentsPage listview
  - A touch of visual cleaning in the comment delegate
  - Type-safe comparisons are good
  - Throttle the fetch calls just a touch, no reason to be spammy

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60920=61065

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-01 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60920.
leinir added a comment.


  - Uncrash the author hash (don't use const QString references as key...)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60781=60920

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-28 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60781.
leinir added a comment.


  Bunch of work on the comments (especially avatar stuff). In progress, of 
course, but the concept is there
  
  - Add an Author component to the QtQuick bits
  - Add Providers functionality for fetching person data
  - Add avatar and description fields to the KNSCore::Author class
  - Clean up the depth count (and less crashing)
  - Add author details to the QtQuick ItemsModel
  - We're version 1.1
  - Remember to remember the namespace
  - The cards listview is great... but i need indentation :/
  - Use the new magic Author component

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60729=60781

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-27 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60729.
leinir added a comment.


  - Work on the comments delegate's look some

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60689=60729

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-26 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60689.
leinir added a comment.


  - Fill the width in the dialog's sidebar with Button
  - Use the knsrc file's Name attr for title (already translated)
  - Indent the comments by their depth (this is imperfect, but...)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60214=60689

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-21 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60214.
leinir added a comment.


  Address  anthonyfieroni's comment about manual memory management in the 
comments fetching system
  
  - Switch to a shared_ptr list for comments (less manual memory mgmnt)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60204=60214

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-21 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  QList should be QList>, don't 
leave ownership to consumers.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-21 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60204.
leinir added a comment.


  - Sort the default sizing on the Dialog to be more pleasant
  - Rejig the Dialog's button implementation, so it's now got shortcuts
  - Set the default column width of the test dialog

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60181=60204

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-21 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60181.
leinir added a comment.


  - A pile of style cleaning
  - Implement the adoptItem function in KNSQuick::ItemsModel

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60052=60181

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-19 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60052.
leinir marked 2 inline comments as done.
leinir added a comment.


  Address pino's comments about BIC (and some documentation)
  
  - Don't mark functions virtual which should not be virtual
  - Apply the signal/slot virt func workaround for improved BIC
  - Add a bit more documentation (and some @since)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60021=60052

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-19 Thread Dan Leinir Turthra Jensen 
leinir marked 2 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> pino wrote in engine.h:471
> BIC change, you cannot add virtual  functions in a public class

That shouldn't be virtual anyway, not sure why i did that...

> pino wrote in provider.h:148
> BIC change, you cannot add virtual  functions in a public class

That's a fair bit more annoying... Oh well, signal-based workaround it is, i 
guess (not like we have a lot of providers anyway ;) )

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-18 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> engine.h:471
> + */
> +virtual CommentsModel* commentsForEntry(const KNSCore::EntryInternal 
> );
> +

BIC change, you cannot add virtual  functions in a public class

> provider.h:148
>  virtual void loadPayloadLink(const EntryInternal , int linkId) = 0;
> +virtual void loadComments(const EntryInternal &, int, int) {};
>  

BIC change, you cannot add virtual  functions in a public class

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-18 Thread Dan Leinir Turthra Jensen 
leinir updated this revision to Diff 60021.
leinir added a comment.


  Highlights: NewStuffButton, basic Kiosk support (needs more clever and 
user-facing mention of why the thing they just tried to do didn't happen/do 
anything), various fixing, cleanup, and sanity work.
  
  - Fix logic for canFetchMore (initial state was a touch funny)
  - Explicitly request the listed categories for searching
  - Fix the emptiness issue in the proper place, and properly
  - Don't need to set this, now it's a proper model
  - Slightly more roundabout, but saner way for the API to handle the engine
  - Missed two files in previous commit
  - Allow opening any random knsrc file on the user's system
  - Expose a changedEntries property on the KNSQuick Engine
  - Import the proper NewStuff version
  - Add the initial version of a KNSQuick Button
  - Add a NewStuff.Button to the khns-dialog test app
  - Add allowedByKiosk in the Quick engine, and expose it
  - Add allowedByKiosk, and mark a few things invokable
  - Add a NewStuffDialog component (and content)
  - Minor doc change
  - Add the NewStuffDialog and NewStuffDialogContent components
  - Much simpler NewStuffButton (and use the Engine's kiosk info)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=59510=60021

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-13 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  In D21721#478676 , @ngraham wrote:
  
  > Could the new one be API compatible so we wouldn't need to wait for KF6? 
Also it's always nice to avoid breaking API if you don't have to.
  
  
  Not entirely sure we can do that, the old KNewStuff widgets are quite tightly 
bound to the widget world... It might be possible with a touch of heavy duty 
header wrangling (keeping it abi compatible would be a fair bit of work, though 
not impossible). At the very least, though, i'd like to perhaps do that as a 
sort of... second step after these components have been created. In short: 
Doable, but quite possibly more work than it'd be worth (when compared to 
straight up deprecation-and-porting-guide).

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  Could the new one be API compatible so we wouldn't need to wait for KF6? Also 
it's always nice to avoid breaking API if you don't have to.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-12 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  In D21721#478241 , @ngraham wrote:
  
  > Thanks! I think we should definitely aim to replace the old QWidgets-based 
one. Otherwise we're signing up for an increased maintenance burden with no 
real advantages IMO. Consider that we already have the GHNS dialog as well as 
Discover's UI, and each one has subtle bugs fixed in the other one. Adding a 
third frontend for the same data would make this even worse. Ideally over time 
we move to just having one desktop-based frontend (this one maybe?) with 
multiple ways to access it.
  
  
  Yeah - obviously we can't rip out the old one yet, but we can mark it 
deprecated and pending removal in KF6 :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-11 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks! I think we should definitely aim to replace the old QWidgets-based 
one. Otherwise we're signing up for an increased maintenance burden with no 
real advantages IMO. Consider that we already have the GHNS dialog as well as 
Discover's UI, and each one has subtle bugs fixed in the other one. Adding a 
third frontend for the same data would make this even worse. Ideally over time 
we move to just having one desktop-based frontend (this one maybe?) with 
multiple ways to access it.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-11 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  In D21721#477397 , @ngraham wrote:
  
  > How does one test this?
  
  
  By running the khotnewstuff-dialog application and passing a knsrc file to it 
(though i would point to the first line in the summary for the moment before 
you do too much testing ;) ).
  
  > Does it replace the existing one?
  
  It is supposed to end up at feature parity with the Widget based tools, but 
not entirely replace that (perhaps as much as deprecate). It is not quite 
intended as a drop-in replacement, but rather i'm building it so it is more 
flexible than the old system, which will allow people to embed it more tightly 
in their applications, or have it almost entirely disconnected, as they wish.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-10 Thread Nathaniel Graham 
ngraham added a comment.


  How does one test this? Does it replace the existing one?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-10 Thread Dan Leinir Turthra Jensen 
leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-10 Thread Dan Leinir Turthra Jensen 
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Basic KNewStuffQuick dialog for testing purposes
  
  Actually return the number of comments, not the rating
  
  Change the install overwrite question to YesNo
  
  It was previously a very uninformative question, so rewording
  it to a YesNo question, with more verbosity, seems reasonable,
  given this is potentially destructive.
  
  Add a QuestionListener for KNewStuffQuick
  
  This was promised in the documentation already, and missing,
  which is a bit silly. Let's just implement that ;)
  
  Add the Question enums to its metaobject
  
  Expose method to get the row of a specific EntryInternal
  
  Add the QtQuick QuestionAsker component
  
  A component used to forward questions from KNewStuff's
  engine to the UI, similar to how the KNewStuff::WidgetQuestionListener
  class works.
  
  Slightly modified GridDelegate, to allow for a tile style view
  
  Based on the KCM GridDelegate
  
  Add the Ratings component from Discover
  
  Should this perhaps be in a more centrally usable location? Seems
  like something we'd probably want to be using in more locations,
  for a more consistent look when ratings are involved...
  
  Add a model exposing categories metadata to QtQuick
  
  A model to care for the comments for a single EntryInternal
  
  This is a step along the way to add comment support to KNewStuff
  
  Actually build the CommentsModel
  
  Implement support for Attica's comments support in KNSCore::Provider
  
  Add some getters to KNSCore::Engine (name, search fields, and comments)
  
  Expose the various new functionality in KNSCore::Engine
  
  This includes the name, categories, and filter and sort options
  
  Add Comments, adoption and full installation support to Quick ItemsModel
  
  Actually build and expose our various new classes in KNewStuffQuick
  
  Add a screenshots display component, based heavily on Discover's
  
  Very basic (for now) comment delegate
  
  A Kirigami.ScrollablePage for showing an entry's comments
  
  A Kirigami.OverlaySheet for picking a specific DownloadItem to install
  
  Add a component for viewing an Entry's details (KCM.SimpleKCM based)
  
  Add a DownloadDialog equivalent to KNewStuffQuick
  
  This page is partly based on design work found on:
  https://phabricator.kde.org/D20693#455565
  and partly on discussions with the VDG. The BigPreview delegate
  specifically was envisioned by Andy Betts
  
  Add the new components to the qmldir

REPOSITORY
  R304 KNewStuff

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns