D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Chinmoy Ranjan Pradhan 
chinmoyr closed this revision.
chinmoyr added a comment.


  
https://commits.kde.org/kwidgetsaddons/89606c1ecb571e3ae9137cab18ceadeff57666e3

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21953

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Chinmoy Ranjan Pradhan 
chinmoyr updated this revision to Diff 60250.
chinmoyr added a comment.


  "More Details" -> "Details"

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21953?vs=60198=60250

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

AFFECTED FILES
  src/kmessagebox.cpp

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Björn Feber 
GB_2 accepted this revision.
GB_2 added a comment.


  Thanks! Perhaps just "Details" would be enough.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added reviewers: VDG, ngraham, GB_2.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Remove "Details" button and use KCollapsibleGroupBox to display more details.
  
  F6920180: error detailed 
  
  F6920182: warning detailed 
  
  F6920185: warning detailed expanded 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

AFFECTED FILES
  src/kmessagebox.cpp

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns