D22047: Fix translation of actiondisplay

2019-06-30 Thread Alexander Potashev 
aspotashev added inline comments.

INLINE COMMENTS

> imgurplugin.json:105
> +"Name[zh_TW]": "Imgur",
> +"X-Purpose-ActionDisplay": "Imgur"
>  },

same for Imgur :(

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-30 Thread Alexander Potashev 
aspotashev added inline comments.

INLINE COMMENTS

> pastebinplugin.json:105
> +"Name[zh_TW]": "Pastebin",
> +"X-Purpose-ActionDisplay": "Pastebin"
>  },

oops, ActionDisplay should have ellipsis, e.g. "Pastebin..."

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-23 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:1405e495ccab: Fix translation of actiondisplay (authored 
by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22047?vs=60498=60504

REVISION DETAIL
  https://phabricator.kde.org/D22047

AFFECTED FILES
  src/alternativesmodel.cpp
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-23 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  okay

REPOSITORY
  R495 Purpose Library

BRANCH
  unfuckup

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-23 Thread Nicolas Fella 
nicolasfella added a comment.


  @aacid and I have been working on making it possible to translate arbitrary 
JSON entries. See https://phabricator.kde.org/R883:1544734

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-23 Thread Pino Toscano 
pino added a comment.


  I do not see how this is supposed to fix the translations. Nothing translates 
the strings statically (like the various `Name`/`Comment`/etc), nor at runtime.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

2019-06-23 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: apol, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  To be able to be translated the entries need to be subentry of KPlugin

REPOSITORY
  R495 Purpose Library

BRANCH
  unfuckup

REVISION DETAIL
  https://phabricator.kde.org/D22047

AFFECTED FILES
  src/alternativesmodel.cpp
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json

To: nicolasfella, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns